rpmlint complains about "script-without-shebang" due to the execute
permissions on /usr/share/bash-completion/completions/vsh. Use
INSTALL_DATA instead of INSTALL_SCRIPT to avoid the unnecessary
execute permissions.

Signed-off-by: Jim Fehlig <jfeh...@suse.com>
---

BTW, of the nearly 800 files in /usr/share/bash-completion/completions/
on my installation, only vsh has execute permissions set.

 tools/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/Makefile.am b/tools/Makefile.am
index 426a6ba661..d9d1a2f43f 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -357,7 +357,7 @@ libvirt-guests.service: libvirt-guests.service.in 
$(top_builddir)/config.status
 if WITH_BASH_COMPLETION
 install-bash-completion:
        $(MKDIR_P) "$(DESTDIR)$(BASH_COMPLETIONS_DIR)"
-       $(INSTALL_SCRIPT) $(srcdir)/bash-completion/vsh \
+       $(INSTALL_DATA) $(srcdir)/bash-completion/vsh \
                "$(DESTDIR)$(BASH_COMPLETIONS_DIR)/vsh"
        ( cd $(DESTDIR)$(BASH_COMPLETIONS_DIR) && \
                rm -f virsh virt-admin && \
-- 
2.16.4


Reply via email to