On Thu, Feb 6, 2020 at 11:25 AM Jiri Denemark <jdene...@redhat.com> wrote:
> See the last patch for detailed description and > https://bugzilla.redhat.com/show_bug.cgi?id=1795651 for a discussion > about this topic. > > Jiri Denemark (3): > qemu: Pass machine type to virQEMUCapsIsCPUModeSupported > qemuxml2*test: Add default CPU tests for s390-ccw-virtio-2.7 machines > qemu_capabilities: Disable CPU models on old s390 machine types > Reviewed-by: Christian Ehrhardt <christian.ehrha...@canonical.com> I have also set up a build with the changes adding some Ubuntu machine types on top. I eventually also want to give you a Tested-by, but those tests not be completed this week - I beg your pardon for the delay. > src/qemu/qemu_capabilities.c | 29 ++++++++++++++--- > src/qemu/qemu_capabilities.h | 3 +- > src/qemu/qemu_domain.c | 3 +- > src/qemu/qemu_process.c | 2 +- > ...t-cpu-kvm-ccw-virtio-2.7.s390x-latest.args | 32 +++++++++++++++++++ > .../s390-default-cpu-kvm-ccw-virtio-2.7.xml | 16 ++++++++++ > ...t-cpu-tcg-ccw-virtio-2.7.s390x-latest.args | 32 +++++++++++++++++++ > .../s390-default-cpu-tcg-ccw-virtio-2.7.xml | 16 ++++++++++ > tests/qemuxml2argvtest.c | 2 ++ > ...lt-cpu-kvm-ccw-virtio-2.7.s390x-latest.xml | 24 ++++++++++++++ > ...lt-cpu-tcg-ccw-virtio-2.7.s390x-latest.xml | 26 +++++++++++++++ > tests/qemuxml2xmltest.c | 2 ++ > 12 files changed, 180 insertions(+), 7 deletions(-) > create mode 100644 > tests/qemuxml2argvdata/s390-default-cpu-kvm-ccw-virtio-2.7.s390x-latest.args > create mode 100644 > tests/qemuxml2argvdata/s390-default-cpu-kvm-ccw-virtio-2.7.xml > create mode 100644 > tests/qemuxml2argvdata/s390-default-cpu-tcg-ccw-virtio-2.7.s390x-latest.args > create mode 100644 > tests/qemuxml2argvdata/s390-default-cpu-tcg-ccw-virtio-2.7.xml > create mode 100644 > tests/qemuxml2xmloutdata/s390-default-cpu-kvm-ccw-virtio-2.7.s390x-latest.xml > create mode 100644 > tests/qemuxml2xmloutdata/s390-default-cpu-tcg-ccw-virtio-2.7.s390x-latest.xml > > -- > 2.25.0 > > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd