OK. Get it On Wed, Apr 22, 2020 at 4:49 PM Peter Krempa <pkre...@redhat.com> wrote:
> On Wed, Apr 22, 2020 at 16:28:06 +0800, Han Han wrote: > > On Wed, Apr 22, 2020 at 4:14 PM Peter Krempa <pkre...@redhat.com> wrote: > > > > > On Tue, Apr 21, 2020 at 20:19:34 +0800, Han Han wrote: > > > > Add io_uring value to capability replies. > > > > > > > > The capability QEMU_CAPS_AIO_IO_URING will be used for io_uring aio > mode, > > > > introduced from QEMU 5.0, linux 5.1. > > > > > > > > Signed-off-by: Han Han <h...@redhat.com> > > > > --- > > > > src/qemu/qemu_capabilities.c | 2 ++ > > > > src/qemu/qemu_capabilities.h | 1 + > > > > tests/qemucapabilitiesdata/caps_5.0.0.aarch64.replies | 3 ++- > > > > tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml | 1 + > > > > tests/qemucapabilitiesdata/caps_5.0.0.ppc64.replies | 3 ++- > > > > tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + > > > > tests/qemucapabilitiesdata/caps_5.0.0.x86_64.replies | 3 ++- > > > > tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml | 1 + > > > > 8 files changed, 12 insertions(+), 3 deletions(-) > > > > > > [...] > > > > > > > diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.replies > > > b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.replies > > > > index af2299a4..970e483e 100644 > > > > --- a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.replies > > > > +++ b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.replies > > > > @@ -22244,7 +22244,8 @@ > > > > "meta-type": "enum", > > > > "values": [ > > > > "threads", > > > > - "native" > > > > + "native", > > > > + "io_uring" > > > > > > Did you patch this manually? > > > > > > Yes > > Okay, please don't do that in the future. The idea of the 'replies' > files is that they are captured from real qemu. I've currently modified > my qemu install to contain liburing so I'll post the updated ones. > > I'll also drop any other hunks related to 'replies' in this patch when > I'll be pushing this. > > -- Best regards, ----------------------------------- Han Han Quality Engineer Redhat. Email: h...@redhat.com Phone: +861065339333