On Fri, Aug 07, 2020 at 04:59:12PM +0200, Pavel Hrdina wrote: > Commit <2020c6af8a8e4bb04acb629d089142be984484c8> fixed an issue with > QEMU driver by reporting offline CPUs as well. However, doing so it > introduced a regression into libxl and test drivers by completely > ignoring the passed `hostcpus` variable. > > Move the virHostCPUGetAvailableCPUsBitmap() out of the helper into QEMU > driver so it will not affect other drivers which gets the number of host > CPUs differently. > > This was uncovered by running libvirt-dbus test suite which counts on > the fact that test driver has hard-coded host definition and must not > depend on the host at all. > > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/conf/domain_conf.c | 18 +++++------------- > src/conf/domain_conf.h | 4 ++-- > src/libxl/libxl_driver.c | 7 ++++++- > src/qemu/qemu_driver.c | 6 +++++- > src/test/test_driver.c | 8 ++++++-- > 5 files changed, 24 insertions(+), 19 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
