On Wed, Nov 11, 2020 at 11:15:33AM +0100, Boris Fiuczynski wrote: > On 11/11/20 10:39 AM, Erik Skultety wrote: > > On Tue, Nov 10, 2020 at 07:09:06PM +0100, Boris Fiuczynski wrote: > > > Add detection of mdev_types capability to channel subsystem devices. > > > > > > Signed-off-by: Boris Fiuczynski <fiu...@linux.ibm.com> > > > Reviewed-by: Bjoern Walk <bw...@linux.ibm.com> > > > --- > > > docs/drvnodedev.html.in | 5 +- > > > docs/formatnode.html.in | 19 +++- > > > docs/schemas/nodedev.rng | 4 + > > > src/conf/node_device_conf.c | 92 ++++++++++++++++++- > > > src/conf/node_device_conf.h | 11 +++ > > > src/conf/virnodedeviceobj.c | 7 +- > > > src/libvirt_private.syms | 1 + > > > src/node_device/node_device_udev.c | 3 + > > > .../css_0_0_fffe_mdev_types.xml | 17 ++++ > > > tests/nodedevxml2xmltest.c | 1 + > > > 10 files changed, 153 insertions(+), 7 deletions(-) > > > create mode 100644 tests/nodedevschemadata/css_0_0_fffe_mdev_types.xml > > > > > > diff --git a/docs/drvnodedev.html.in b/docs/drvnodedev.html.in > > > index 0823c1888d..d5191d6d93 100644 > > > --- a/docs/drvnodedev.html.in > > > +++ b/docs/drvnodedev.html.in > > > @@ -139,12 +139,13 @@ > > > <h3><a id="MDEVCap">MDEV capability</a></h3> > > > <p> > > > - A PCI device capable of creating mediated devices will include a > > > nested > > > + A device capable of creating mediated devices will include a nested > > > capability <code>mdev_types</code> which enumerates all supported > > > mdev > > > types on the physical device, along with the type attributes > > > available > > > through sysfs. A detailed description of the XML format for the > > > <code>mdev_types</code> capability can be found > > > - <a href="formatnode.html#MDEVCap">here</a>. > > > + <a href="formatnode.html#MDEVCap">here for PCI</a> or > > > + <a href="formatnode.html#MDEVCapCSS">here for CSS</a>. > > > > Both PCI and CSS mdev_types are just a pointer to the mdev_types XML > > element. > > How about just fixing the href to MDEVTypesCap? > > That is fine since from there one gets the list of devices as well. > But than let us cleanly rename the ids in docs/formatnode.html.in as > follows: > > MDEVCap => MDEVTypesCapPCI > MDEVCapCSS => MDEVTypesCapCSS > MDevTypesCap => MDEVTypesCap
Okay, makes sense, but that should come to a trivial standalone patch. I'll let you quickly respin with that along with the other nits, I'll approve and you can then apply what's necessary on Shalini's series :). Erik
