On Mon, Nov 23, 2020 at 12:39:51PM -0500, Matt Coleman wrote:
> Changes since v2:
> * raise an error if the parent device cannot be located
> * correct the disk count and use constants instead of magic numbers
> 
> Here's a GitLab MR if you'd prefer to review it there:
> https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/commits
> 
> This link shows a diff between v2 and v3:
> https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/diffs?diff_id=126400840&start_sha=6c5a3dfc2bf2f13c0d9765f00b53b15043693517
> 
> Matt Coleman (2):
>   hyperv: XML parsing of storage volumes
>   schema: add support for Windows file paths and device names

Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>

and pushed


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Reply via email to