QEMU has long accepted many different values for boolean properties, but set accepted has been different depending on which QEMU parser you hit.
The on|off values were supported by all QEMU parsers. The yes|no, y|n, true|false values were only partially supported: https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg01012.html Thus we should standardize on on|off everywhere since that is most widely supported in QEMU. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/util/virqemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virqemu.c b/src/util/virqemu.c index 4136012c70..5b0dc25bc1 100644 --- a/src/util/virqemu.c +++ b/src/util/virqemu.c @@ -362,7 +362,7 @@ virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr srcdef) { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - if (virQEMUBuildCommandLineJSON(srcdef, &buf, NULL, false, + if (virQEMUBuildCommandLineJSON(srcdef, &buf, NULL, true, virQEMUBuildCommandLineJSONArrayNumbered) < 0) return NULL; -- 2.29.2