On Wed, May 12, 2021 at 04:01:26PM +0000, Douglas, William wrote:
> On Tue, May 11, 2021 at 02:05AM, Daniel P. Berrangé wrote:
> > On Tue, Apr 27, 2021 at 02:39:46PM -0700, William Douglas wrote:
> >> diff --git a/meson.build b/meson.build
> >> index 951da67896..8c33efb25c 100644
> >> --- a/meson.build
> >> +++ b/meson.build
> >> @@ -1517,6 +1517,48 @@ elif get_option('driver_lxc').enabled()
> >> error('linux and remote_driver are required for LXC')
> >> endif
> >>
> >> +if not get_option('driver_ch').disabled() and host_machine.system() ==
> >> 'linux'
> >
> > This logic will end up enabling cloud-hypervisor by default on
> > all architectures. You mention earlier it only targets 64-bit.
> > What about the more obscure 64-bit archs like s390x/ppc64 ?
> > This will build cloud-hypervisor on those archs right now.
> > Does this need to have an arch restriction.
>
> Ah that's a good point, I'll add a check on host_machine.cpu_family
> for 'x86_64'. Is that the right way to handle it?
Yeah that seems to match what we've done elsewhere.
You need aarch64 too I think ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
