On 6/15/21 4:16 PM, Peter Krempa wrote: > The 'rbd_image_spec_t' struct has two string members 'id' and > 'name'. We only stole the 'name' members thus the 'id's as well as the > whole list would be leaked on success. > > Restructure the code so that we copy out the image names and call > rbd_image_spec_list_cleanup on success rather than on error. > > The error path is then handled by using g_autofree for 'images'. > > Since we no longer have a error path after allocating the returned > string list we can completely remove it's cleanup.
*its > > Signed-off-by: Peter Krempa <pkre...@redhat.com> > --- > src/storage/storage_backend_rbd.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) Reviewed-by: Ján Tomko <jto...@redhat.com> Jano
