Re: [PATCH] ci: Also perform `brew upgrade` on MacOS

[Martin Kletzander]

On Wed, Jun 16, 2021 at 06:21:00AM -0700, Andrea Bolognani wrote:

On Tue, Jun 15, 2021 at 12:43:39PM +0200, Martin Kletzander wrote:

ci: Also perform `brew upgrade` on MacOS

s/MacOS/macOS/

But see below for why we might have to change the subject even
further.

@Andrea: if you have a good explanation you'd like to put in the commit message,
I'd me glad to add it (or you can do that as well).  Thanks

I think something like

 The base OS image might include outdated contents, and we don't
 want to get spurious failures caused by bugs that have already been
 fixed in the respective packages.

 This is particularly important on macOS, because 'brew install foo'
 will fail if 'foo' is already installed but outdated: upgrading all
 packages first ensures we never run into this scenario.

would about sum it up.

@@ -443,6 +444,7 @@ x64-macos-11-build:
     CIRRUS_VM_IMAGE_SELECTOR: image
     CIRRUS_VM_IMAGE_NAME: big-sur-base
     UPDATE_COMMAND: brew update
+    UPGRADE_COMMAND: brew upgrade

I believe you also need to add

 UPGRADE_COMMAND: pkg upgrade -y

to the FreeBSD jobs: I don't think Cirrus CI would appreciate having
a completely empty string in the list of commands it's supposed to
run.

It does not cause any issues on libnbd setup where the upgrade is run
only on macOS.

With that squashed in,

 Reviewed-by: Andrea Bolognani <abolo...@redhat.com>

Are you suggesting that I add the `pkg upgrade -y` to FreeBSDs as well
here?  Because then the commit message would not fit the patch.

and thanks for taking care of this :)

and sorry for forgetting about this =)

--
Andrea Bolognani / Red Hat / Virtualization

signature.asc
Description: PGP signature