On Thu, Sep 30, 2021 at 01:39:20AM +0000, Huang, Haibin wrote: > > > > -----Original Message----- > > From: Daniel P. Berrangé <berra...@redhat.com> > > Sent: Tuesday, September 28, 2021 10:15 PM > > To: Huang, Haibin <haibin.hu...@intel.com> > > Cc: libvir-list@redhat.com; Ding, Jian-feng <jian-feng.d...@intel.com>; > > Yang, > > Lin A <lin.a.y...@intel.com>; Lu, Lianhao <lianhao...@intel.com>; > > pbonz...@redhat.com; pkre...@redhat.com; twied...@redhat.com; > > phrd...@redhat.com; mpriv...@redhat.com > > Subject: Re: [libvirt][PATCH v7 5/5] Add get domaincaps unit test > > > > On Wed, Sep 08, 2021 at 09:15:58AM +0800, Haibin Huang wrote: > > > Signed-off-by: Haibin Huang <haibin.hu...@intel.com> > > > --- > > > tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + > > > tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + > > > tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + > > > tests/domaincapsdata/empty.xml | 1 + > > > tests/domaincapsdata/libxl-xenfv.xml | 1 + > > > tests/domaincapsdata/libxl-xenpv.xml | 1 + > > > tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + > > > tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + > > > tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + > > > tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.4.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.4.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.4.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.5.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.5.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.5.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.6.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.6.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.6.0-virt.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_2.6.0.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 + > > > tests/domaincapsdata/qemu_2.6.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.7.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.7.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 + > > > tests/domaincapsdata/qemu_2.7.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.8.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.8.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 + > > > tests/domaincapsdata/qemu_2.8.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.9.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.9.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 + > > > tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 + > > > tests/domaincapsdata/qemu_2.9.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + > > > tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + > > > tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + > > > tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_4.0.0-virt.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + > > > tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + > > > tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_4.2.0-virt.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + > > > tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + > > > tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_5.0.0-virt.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + > > > tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + > > > tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_5.2.0-virt.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + > > > tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + > > > tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_6.0.0-virt.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 1 + > > > tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + > > > tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + > > > tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 + > > > 94 files changed, 94 insertions(+) > > > > I'm pretty sure this would be needed in the same patch that wires up domain > > capabilities to report SGX. > > > > I'd expect to also see an update of tests/qemucapabilitiesdata in the patch > > that > > probes the QEMU feature in qemu_capabilities.c > > > > I totally agree to sperate two patches, one for probe the qemu capabilities, > the > other for adding domain capability and adding corresponding unit test. just > double > confirm the unit test should be put in the same patch with function > implementation?
Yes, 'ninja test' must succeed at every individual patch, so you'll be forced to put the unit test changes in the same patch that adds the capability. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
