On 10/15/21 11:49 AM, Hiroki Narukawa wrote: > query-dirty-rate command is used for virsh domstats regardless of qemu > version, but this is available only on qemu >=5.2.0. > > So virsh domstats fails if qemu is older. > > This patchset fixes the bug. > > I added it to NEWS because I thought it is a bug that users want to find, but > if it is not so please simply ignore the last commit. > > > Hiroki Narukawa (4): > qemu_capabilities: Add QEMU_CAPS_QUERY_DIRTY_RATE capability > qemu_driver: add required capabilities to qemuDomainGetStatsWorkers > qemu_driver: add check for qemu capabilities requirements > NEWS: document bug fix about virsh domstats on qemu < 5.2.0 > > NEWS.rst | 5 ++ > src/qemu/qemu_capabilities.c | 2 + > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_driver.c | 72 +++++++++++++------ > .../caps_5.2.0.aarch64.xml | 1 + > .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + > .../caps_5.2.0.riscv64.xml | 1 + > .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + > .../caps_5.2.0.x86_64.xml | 1 + > .../caps_6.0.0.aarch64.xml | 1 + > .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + > .../caps_6.0.0.x86_64.xml | 1 + > .../caps_6.1.0.x86_64.xml | 1 + > .../caps_6.2.0.x86_64.xml | 1 + > 14 files changed, 68 insertions(+), 22 deletions(-) >
In general: Reviewed-by: Michal Privoznik <mpriv...@redhat.com> But please see my comment to individual patches and let me know whether you agree with my suggestions. I can squash them in and push then. Michal
