On 10/22/21 5:37 PM, Praveen K Paladugu wrote:
> From: Vineeth Pillai <virem...@linux.microsoft.com>
> 
> Signed-off-by: Vineeth Pillai <virem...@linux.microsoft.com>
> Signed-off-by: Praveen Paladugu <pra...@linux.microsoft.com>
> Signed-off-by: Praveen K Paladugu <pra...@linux.microsoft.com>
> ---
>  src/ch/ch_conf.h    |  5 +++
>  src/ch/ch_domain.c  | 26 +++++++++++++-
>  src/ch/ch_domain.h  |  4 +--
>  src/ch/ch_driver.c  |  4 ++-
>  src/ch/ch_monitor.c | 85 +++++++++++++++++++++++++++++++++++++++++----
>  src/ch/ch_monitor.h | 14 +++++++-
>  src/ch/ch_process.c |  6 +++-
>  src/ch/meson.build  |  1 +
>  8 files changed, 132 insertions(+), 13 deletions(-)
> 
> diff --git a/src/ch/ch_conf.h b/src/ch/ch_conf.h
> index 37c36d9a09..49f286f97a 100644
> --- a/src/ch/ch_conf.h
> +++ b/src/ch/ch_conf.h
> @@ -44,6 +44,11 @@ struct _virCHDriver
>  {
>      virMutex lock;
>  
> +    bool privileged;
> +
> +    /* Embedded Mode: Not yet supported */
> +    char *embeddedRoot;

I'd rather not introduce this member and pass NULL to
virDomainDriverGenerateMachineName() below directly. embeddedRoot is
completely different beast and it may create false beliefs upon seeing
this declaration.

Michal

Reply via email to