Commit 73a2ff36163e already improved the situation a lot. This
pushes things even further.

If the user or, more likely, the distro packager explicitly
asked for ZFS support to be enabled, then we should comply with
that request regardless of whether the necessary programs are
available at build time.

This is particularly important in the context of Debian, where
ZFS cannot be a build dependency of libvirt due to licensing
issues but it can still be an optional runtime dependency.

Signed-off-by: Andrea Bolognani <abolo...@redhat.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 3a9066b9fe..5b73713e50 100644
--- a/meson.build
+++ b/meson.build
@@ -1978,7 +1978,7 @@ if conf.has('WITH_LIBVIRTD')
     foreach name : [ 'zfs', 'zpool' ]
       set_variable(
         '@0@_prog'.format(name),
-        find_program(name, required: get_option('storage_zfs'), dirs: 
libvirt_sbin_path)
+        find_program(name, required: false, dirs: libvirt_sbin_path)
       )
     endforeach
 
-- 
2.31.1

Reply via email to