On 12/14/21 20:21, Michal Prívozník wrote:
On 12/14/21 10:22, Michal Prívozník wrote:
On 11/23/21 15:36, huang...@chinatelecom.cn wrote:
From: Hyman Huang(黄勇) <huang...@chinatelecom.cn>
Dirty ring feature was introduced in qemu-6.1.0, this patch
add the corresponding feature named 'dirty-ring', which enable
dirty ring feature when starting vm.
To implement the dirty-ring feature, dirty_ring_size in struct
"_virDomainDef" is introduced to hold the dirty ring size
configured in xml, and it will be used as dirty-ring-size
property of kvm accelerator when building qemu commandline,
it is something like "-accel dirty-ring-size=xxx".
To enable the feature, the following XML needs to be added to
the guest's domain description:
<features>
<kvm>
<dirty-ring state='on' size='xxx'>
</kvm>
</features>
If property "state=on", property "size" must be specified, which
should be power of 2 and range in [1024, 65526].
Signed-off-by: Hyman Huang(黄勇) <huang...@chinatelecom.cn>
---
docs/formatdomain.rst | 18 ++++++------
docs/schemas/domaincommon.rng | 10 +++++++
src/conf/domain_conf.c | 54 +++++++++++++++++++++++++++++++++++
src/conf/domain_conf.h | 4 +++
src/qemu/qemu_command.c | 12 ++++++++
5 files changed, 90 insertions(+), 8 deletions(-)
So here's what I suggest doing - let me post a patch that changes 'int
kvm_features' into a separate struct. I would squash it into yours but
it turned out to be quite lengthy change. Then I'll do changes necessary
for your patch (which will be trivial after that).
Merged now. Congratulations on your first libvirt contribution!
Michal
Thanks :)
--
Best Regards
Hyman Huang(黄勇)
