On Thu, Dec 30, 2021 at 08:01:43 +0200, Andrew Melnychenko wrote: > Added "rss" and "rss_hash_report" configuration that should be used with > qemu virtio RSS. > Both options are triswitches. Used as "driver" options and affects only NIC > with model type "virtio". > In other patches - options should turn on virtio-net RSS and hash properties. > > Signed-off-by: Andrew Melnychenko <and...@daynix.com> > --- > docs/formatdomain.rst | 15 +++++++++++++++ > docs/schemas/domaincommon.rng | 10 ++++++++++ > src/conf/domain_conf.c | 31 ++++++++++++++++++++++++++++++- > src/conf/domain_conf.h | 2 ++ > 4 files changed, 57 insertions(+), 1 deletion(-) > > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst > index d4f30bb8af..f7b784ed26 100644 > --- a/docs/formatdomain.rst > +++ b/docs/formatdomain.rst > @@ -5305,6 +5305,21 @@ following attributes are available for the > ``"virtio"`` NIC driver: > only for ``vhostuser`` type. :since:`Since 3.7.0 (QEMU and KVM only)` > **In general you should leave this option alone, unless you are very > certain > you know what you are doing.** > +``rss`` > + The ``rss`` option enables in-qemu/ebpf RSS for virtio NIC. RSS works with > + virtio and tap backends only. Virtio NIC will be launched with "rss" > + property. Qemu may load eBPF RSS if it has CAP_SYS_ADMIN permissions.
Use 'QEMU' spelling here. > + In other cases, "in-qemu" RSS is used. > + **In general you should leave this option alone, unless you are very > certain > + you know what you are doing.** > +``rss_hash_report`` > + The ``rss_hash_report`` option enables in-qemu RSS hash report for virtio > + NIC. Virtio NIC will be launched with "hash" property. Ebpf RSS doesn't > + support hash report yet. Usually enabled alongside with ``rss``. > + Without ``rss`` option, the hash report doesn't affect steering > + itself but provides vnet header with a calculated hash. > + **In general you should leave this option alone, unless you are very > certain > + you know what you are doing.** > virtio options > For virtio interfaces, `Virtio-specific options <#elementsVirtio>`__ can > also > be set. ( :since:`Since 3.5.0` ) >From this description it's not clear what's happening, could you describe a bit more what's happening here. Also it would be great to have more guidance than "do not touch this setting" .
