On Tue, Jan 04, 2022 at 02:47:08PM +0100, Martin Kletzander wrote: > The only difference is that we are not going to be guaranteed that the mutex > is > normal (as opposed to recursive, although there is no system known to me that > would default to recursive mutexes), but that was done only to find occasional > errors (during runtime, back in 2010, commit 336fd879c00b). Functions using > this mutex are mostly stable and unchanging, and it makes the virLogOnceInit() > function only return 0 (or possibly abort in glib calls). On top of that we > can > assume that the virLogMutex is always initialized which enables us to be more > consistent in some early error reporting. > > Signed-off-by: Martin Kletzander <mklet...@redhat.com> > --- Reviewed-by: Erik Skultety <eskul...@redhat.com>
- [PATCH 0/8] Fix an unfortunate deadlock Martin Kletzander
- [PATCH 3/8] util: Report error in virLogSetDefaultO... Martin Kletzander
- Re: [PATCH 3/8] util: Report error in virLogSet... Erik Skultety
- [PATCH 2/8] util: Do not hide errors in virLogSetDe... Martin Kletzander
- Re: [PATCH 2/8] util: Do not hide errors in vir... Erik Skultety
- [PATCH 4/8] util: Initialize virLogMutex statically Martin Kletzander
- Re: [PATCH 4/8] util: Initialize virLogMutex st... Erik Skultety
- [PATCH 5/8] Exit on errors from virDaemonSetupLoggi... Martin Kletzander
- Re: [PATCH 5/8] Exit on errors from virDaemonSe... Erik Skultety
- [PATCH 1/8] util: Report error in virLogParseDefaul... Martin Kletzander
- Re: [PATCH 1/8] util: Report error in virLogPar... Erik Skultety
- [PATCH 6/8] util: Check for errors in virLogSetFrom... Martin Kletzander
- Re: [PATCH 6/8] util: Check for errors in virLo... Erik Skultety
- Re: [PATCH 6/8] util: Check for errors in v... Martin Kletzander
- [PATCH 8/8] Do not print error in remote_daemon.c:m... Martin Kletzander
- Re: [PATCH 8/8] Do not print error in remote_da... Erik Skultety
- [PATCH 7/8] Dispatch error in virInitialize Martin Kletzander