"Daniel P. Berrange" <berra...@redhat.com> wrote on 03/26/2010 04:44:49 PM:
> On Fri, Mar 26, 2010 at 02:41:30PM -0400, Stefan Berger wrote: > > "Daniel P. Berrange" <berra...@redhat.com> wrote on 03/26/2010 02:04:26 > > PM: > > [...] > > > > > > has a dependancy on the driver implementation nwfilter/ > > > nwfilter_gentech_driver.h > > > which is not good. The 'conf' directory is only allowed to depend on > > stuff > > > in util/, or itself, never depend on driver code. > > > > > > From nwfilter_conf.c I call several functions of the > > nwfilter_gentech_driver.c from within an iterator callback function. Is > > the general right solution for this to have nwfilter_gentech_driver.c > > register an interface with nwfilter_conf.c that provides the addresses of > > those functions call from within nwfilter_conf.c now? If so, I think I > > could pass the callback function to the nwfilter_conf.c and move the > > actual callback function in nwfilter_gentech_driver.c and pass its address > > via the initialization function I call in nwfilter_conf.c from > > nwfilter_gentech_driver.c. > > Cool, that sounds like a good plan Posted the patch that does that on Friday. Regards, Stefan > > Regards, > Daniel > -- > |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/:| > |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org:| > |: http://autobuild.org -o- http://search.cpan.org/~danberr/:| > |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list