Hi Michal, Ok , I have change it like below. Do you mean that? <domainCapabilities> <features> <sgx supported='yes'> <flc>no</flc> <epc_size unit='KiB'>1</epc_size> </sgx> </features> </domainCapabilities>
> -----Original Message----- > From: Michal Prívozník <mpriv...@redhat.com> > Sent: Friday, January 7, 2022 11:06 PM > To: Huang, Haibin <haibin.hu...@intel.com>; libvir-list@redhat.com; Ding, > Jian-feng <jian-feng.d...@intel.com>; Yang, Lin A <lin.a.y...@intel.com>; Lu, > Lianhao <lianhao...@intel.com>; Zhong, Yang <yang.zh...@intel.com> > Subject: Re: [libvirt][PATCH v9 2/5] Transfer Qemu SGX Capabilities to XML > > On 12/15/21 04:40, Haibin Huang wrote: > > Convert qemu sgx capabilities: > > {"sgx": true, "section-size": 0, "flc": false} > > > > to XML format: > > <sgx supported='yes'> > > <flc>no</flc> > > <epc_size unit='KiB'>1</epc_size> > > </sgx> > > > > This should make it obvious which XML you are talking about. It is domain > capabilities XML, or domcaps XML for short. For commit message either is > usable. > > > Signed-off-by: Haibin Huang <haibin.hu...@intel.com> > > --- > > > > 99 files changed, 146 insertions(+), 1 deletion(-) > > > > As I said in previous patch, parts of the patch should be moved into this one, > because domcaps is semantically different change than QEMU querying. > > Also, please don't forget to update documentation: > docs/formatdomaincaps.html.in > > You want probably reference new memory model there, so this patch could > be moved towards the end, after the new memory model was introduced > and documented. > > Michal