On Fri, Feb 11, 2022 at 01:30:26PM +0100, Michal Privoznik wrote: > When rewriting a file using virFileRewrite() and error occurs > while writing into a temporary file it's actually the callback > that can report the most accurate error. Move error reporting > into very few callback we have currently. Those callbacks are > trivial so the benefit of this change is not obvious, but this > will change shortly when slightly more complicated callback is > introduced. > > Signed-off-by: Michal Privoznik <mpriv...@redhat.com> > --- > src/util/virfile.c | 18 ++++++++++++------ > src/util/virfile.h | 4 +++- > src/util/virxml.c | 19 ++++++++++++++----- > 3 files changed, 29 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
