On 04/02/2010 12:11 PM, Stefan Berger wrote:
> The attached patch optimizes the validation of the name of an interface.
>
> Signed-off-by: Stefan Berger
>
> Index: libvirt-acl/src/conf/domain_conf.c
> ===================================================================
> --- libvirt-acl.orig/src/conf/domain_conf.c
> +++ libvirt-acl/src/conf/domain_conf.c
> @@ -1795,7 +1795,7 @@ cleanup:
>
> static bool
> isValidIfname(const char *ifname) {
> - return (strspn(ifname, VALID_IFNAME_CHARS) == strlen(ifname));
> + return ifname[strspn(ifname, VALID_IFNAME_CHARS)] == 0;ACK. -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
