This is one of the standard checks that we have inherited from gnulib, but it's not applicable to libvirt because we don't want plain bindtextdomain() to be used: virGettextInitialize() is our own private API that should be used instead.
The sc_gettext_init check ensures that our private API is used in all the places where it makes sense, and the sc_bindtextdomain check was disabled entirely via a blanket exception. Drop it instead of keeping dead code around. Signed-off-by: Andrea Bolognani <abolo...@redhat.com> --- build-aux/syntax-check.mk | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 6b54f830f1..8689d01f19 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1297,15 +1297,6 @@ sc_prohibit_dirent_without_use: re='\<($(_dirent_syms_re))\>' \ $(_sc_header_without_use) -# Ensure that each .c file containing a "main" function also -# calls bindtextdomain. -sc_bindtextdomain: - @require='bindtextdomain *\(' \ - in_vc_files='\.c$$' \ - containing='\<main *(' \ - halt='the above files do not call bindtextdomain' \ - $(_sc_search_regexp) - sc_trailing_blank: @prohibit='[ ]$$' \ halt='found trailing blank(s)' \ @@ -1578,8 +1569,6 @@ exclude_file_name_regexp--sc_avoid_strcase = ^tools/vsh\.h$$ exclude_file_name_regexp--sc_avoid_write = ^src/libvirt-stream\.c$$ -exclude_file_name_regexp--sc_bindtextdomain = .* - exclude_file_name_regexp--sc_gettext_init = ^((tests|examples)/|tools/virt-login-shell.c|src/util/vireventglib\.c) exclude_file_name_regexp--sc_copyright_usage = \ -- 2.35.3