On 5/23/22 3:08 PM, Michal Privoznik wrote:
The virDomainHostdevSubsysSCSIDefParseXML() function uses old
style of parsing XML (virXMLPropString + str2enum conversion).
Use virXMLPropEnumDefault() which encapsulates those steps.

Signed-off-by: Michal Privoznik<mpriv...@redhat.com>
---
  src/conf/domain_conf.c   | 19 ++++++-------------
  src/conf/domain_conf.h   |  2 +-
  src/qemu/qemu_command.c  |  4 ++--
  src/qemu/qemu_domain.c   |  4 ++--
  src/qemu/qemu_driver.c   |  2 +-
  src/qemu/qemu_process.c  |  2 +-
  tests/qemuxml2argvtest.c |  2 +-
  7 files changed, 14 insertions(+), 21 deletions(-)

Besides what I commented in patch 4

Reviewed-by: Boris Fiuczynski <fiu...@linux.ibm.com>

--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

Reply via email to