On a Friday in 2022, Peter Krempa wrote:
Only the preparation of sources differs between a build from a git
checkout vs a build from tarball. Restructure the docs to outline the
difference and combine information on how to configure libvirt.

Most notably the suggestion to use '-Dsystem=true' was present only for
the steps to build a git checkout.

Suggest also running the testsuite as part of the build step.

Signed-off-by: Peter Krempa <pkre...@redhat.com>
---
docs/compiling.rst | 86 +++++++++++++++++++++++++++++-----------------
1 file changed, 54 insertions(+), 32 deletions(-)

diff --git a/docs/compiling.rst b/docs/compiling.rst
index c167fd238f..1969b9b0b0 100644
--- a/docs/compiling.rst
+++ b/docs/compiling.rst
[...]

-The ``build`` directory now contains the built binaries.
+By default when the ``meson`` is run from within a GIT checkout, it will turn
+on -Werror for builds. This can be disabled with --werror=false, but this is
+not recommended.
+
+**Note:** Please ensure that you have the appropriate minimal ``meson`` version

In a following patch you remove this Note: prefix.
I don't care either way, but please put the final version here, to
reduce churn.

Jano

+installed in your build environment. The minimal version for a specific package
+can be checked in the top level ``meson.build`` file in the ``meson_version``
+field.

Reply via email to