Re: [PATCH 3/4] qemu_namespace: Introduce qemuDomainNamespaceSetupPath()

[Martin Kletzander]

On Mon, Sep 12, 2022 at 03:46:40PM +0200, Michal Privoznik wrote:

Sometimes it may come handy to just bind mount a directory/file
into domain's namespace. Implement a thin wrapper over
qemuNamespaceMknodPaths() which has all the logic we need.

Signed-off-by: Michal Privoznik <mpriv...@redhat.com>

Reviewed-by: Martin Kletzander <mklet...@redhat.com>

---
src/qemu/qemu_namespace.c | 19 +++++++++++++++++++
src/qemu/qemu_namespace.h |  4 ++++
2 files changed, 23 insertions(+)

diff --git a/src/qemu/qemu_namespace.c b/src/qemu/qemu_namespace.c
index 807ec37c91..09e235e120 100644
--- a/src/qemu/qemu_namespace.c
+++ b/src/qemu/qemu_namespace.c
@@ -1424,6 +1424,25 @@ qemuNamespaceUnlinkPaths(virDomainObj *vm,
}


+int
+qemuDomainNamespaceSetupPath(virDomainObj *vm,
+                             const char *path,
+                             bool *created)
+{
+    g_autoptr(virGSListString) paths = NULL;
+
+    if (!qemuDomainNamespaceEnabled(vm, QEMU_DOMAIN_NS_MOUNT))
+        return 0;
+
+    paths = g_slist_prepend(paths, g_strdup(path));
+
+    if (qemuNamespaceMknodPaths(vm, paths, created) < 0)
+        return -1;
+
+    return 0;
+}
+
+
int
qemuDomainNamespaceSetupDisk(virDomainObj *vm,
                             virStorageSource *src,
diff --git a/src/qemu/qemu_namespace.h b/src/qemu/qemu_namespace.h
index fbea865c70..85d990f460 100644
--- a/src/qemu/qemu_namespace.h
+++ b/src/qemu/qemu_namespace.h
@@ -48,6 +48,10 @@ void qemuDomainDestroyNamespace(virQEMUDriver *driver,

bool qemuDomainNamespaceAvailable(qemuDomainNamespace ns);

+int qemuDomainNamespaceSetupPath(virDomainObj *vm,
+                                 const char *path,
+                                 bool *created);
+
int qemuDomainNamespaceSetupDisk(virDomainObj *vm,
                                 virStorageSource *src,
                                 bool *created);
--
2.35.1

signature.asc
Description: PGP signature