On Tue, Oct 11, 2022 at 21:38:26 +0800, Jiang Jiacheng wrote:
> Support updating device's(support cdrom, disk and network) bootindex
> online in virDomainUpdateDeviceFlags. The new bootindex will take effect
> after guest rebooting. Enable bootindex can be set to -1, it means cancel
> the device's bootindex.
> 
> To use this feature, we need to get the device's xml first and modify
> the boot order in the xml, then use 'virsh update-device <domain> <xml>
> --flag' to update the bootindex. Note that the flag should be --config
> or --persistent if the vm is running.

Your series doesn't pass our test suite, namely there are trailing
spaces and missing '%s' in an error message.

Make sure you run the test suite including syntax-check before your next
submission:

https://www.libvirt.org/hacking.html#preparing-patches

Reply via email to