On Thu, Oct 20, 2022 at 16:58:54 -0500, Jonathon Jongsma wrote:
> In order to add caching of the nbdkit capabilities, we will need to
> compare against file modification times, etc. So look up this
> information when creating the nbdkit caps.
> 
> Add a nbdkit_moddir build option to allow the builder to specify the
> location to look for nbdkit plugins and filters.
> 
> Signed-off-by: Jonathon Jongsma <jjong...@redhat.com>
> ---
>  meson.build            |  6 ++++++
>  meson_options.txt      |  1 +
>  src/qemu/qemu_nbdkit.c | 40 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 47 insertions(+)

[...]

> diff --git a/meson_options.txt b/meson_options.txt
> index 861c5577d2..d5ea4376e0 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -71,6 +71,7 @@ option('driver_vbox', type: 'feature', value: 'auto', 
> description: 'VirtualBox X
>  option('vbox_xpcomc_dir', type: 'string', value: '', description: 'Location 
> of directory containing VirtualBox XPCOMC library')
>  option('driver_vmware', type: 'feature', value: 'auto', description: 'VMware 
> driver')
>  option('driver_vz', type: 'feature', value: 'auto', description: 'Virtuozzo 
> driver')
> +option('nbdkit_moddir', type: 'string', value: '', description: 'set the 
> directory where nbdkit modules are located')

Too bad that we don't mention what the default is in the description
message (in other places too).

Reviewed-by: Peter Krempa <pkre...@redhat.com>

Reply via email to