Re: [PATCH 1/9] audio: don't check qemu_add_vm_change_state_handler failure

[Volker Rümelin]

Am 13.01.23 um 17:21 schrieb Daniel P. Berrangé:

This function cannot fail since g_malloc0 aborts on OOM.

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
---
  audio/audio.c | 7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/audio/audio.c b/audio/audio.c
index d849a94a81..7b4b957945 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1712,7 +1712,6 @@ static AudioState *audio_init(Audiodev *dev, const char 
*name)
      size_t i;
      int done = 0;
      const char *drvname = NULL;
-    VMChangeStateEntry *e;
      AudioState *s;
      struct audio_driver *driver;
      /* silence gcc warning about uninitialized variable */
@@ -1830,11 +1829,7 @@ static AudioState *audio_init(Audiodev *dev, const char 
*name)
          s->period_ticks = dev->timer_period * (int64_t)SCALE_US;
      }

- e = qemu_add_vm_change_state_handler (audio_vm_change_state_handler, s);

-    if (!e) {
-        dolog ("warning: Could not register change state handler\n"
-               "(Audio can continue looping even after stopping the VM)\n");
-    }
+    qemu_add_vm_change_state_handler (audio_vm_change_state_handler, s);

checkpatch.pl doesn't work properly here. It should report:
ERROR: space prohibited between function name and open parenthesis '('

With this changed,

Reviewed-by: Volker Rümelin <vr_q...@t-online.de>

QTAILQ_INSERT_TAIL(&audio_states, s, list);

      QLIST_INIT (&s->card_head);