On Thu, Apr 27, 2023 at 09:56:39AM +0200, Michal Prívozník wrote:
On 4/26/23 13:28, Shaleen Bathla wrote:Changes since v1 ================================================================================ - Remove superfluous parenthesis - Update progress as 99.99 instead of 99.00 - Add comment for auto-round-off prevention logic for doubleDescription ================================================================================== While working with active blockcommit using virsh/libvirt, we found that in case of heavy IO, the progress may stay stuck at 99% for quite a while. It will be much better if we show progress upto 2 decimal places more precise which should be sufficient for most scenarios for now. This will give a user, a better understanding of the progress of blockjob/blockcommit etc This patch intends to do exactly that by adding more granularity to blockjob/blockcommit etc progress. Shaleen Bathla (2): tools: virsh-domain: refactor variable initialization tools: virsh-domain: display progress with enhanced granularity tools/virsh-domain.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)Reviewed-by: Michal Privoznik <mpriv...@redhat.com> I'll let Martin share his thoughts though, since he reviewed v1.
My review comments were worked in, so from me Reviewed-by: Martin Kletzander <mklet...@redhat.com> and I'll push it after the release.
Michal
signature.asc
Description: PGP signature
