Re: [PATCH 08/22] qemuBlockStorageSourceGetBlockdevGetCacheProps: Return the cache object rather than appending it

[Ján Tomko]

On a Wednesday in 2023, Peter Krempa wrote:

Signed-off-by: Peter Krempa <pkre...@redhat.com>
---
src/qemu/qemu_block.c  | 29 ++++++++++++++++-------------
src/qemu/qemu_domain.c |  2 +-
2 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 0b36a49bdf..ae19ce884b 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -11442,7 +11442,7 @@ qemuDomainDiskCachemodeFlags(virDomainDiskCache 
cachemode,
     * directsync   ??? false             true           false
     * unsafe       ??? true              false          true
     */
-    switch ((virDomainDiskCache) cachemode) {
+    switch (cachemode) {

This change looks unrelated.

    case VIR_DOMAIN_DISK_CACHE_DISABLE: /* 'none' */
        *writeback = true;
        *direct = true;

Reviewed-by: Ján Tomko <jto...@redhat.com>

Jano

signature.asc
Description: PGP signature