Eric Blake <ebl...@redhat.com> wrote on 09/27/2010 05:17:32 PM:
> > On 09/27/2010 12:40 PM, Stefan Berger wrote: > > + <rule action='accept' direction='in'> > > + <udp-ipv6 srcmacaddr='1:2:3:4:5:6' > > + srcipaddr='a:b:c::' srcipmask='128' > > + dscp='0x40' > > + srcportstart='0x20' srcportend='0x21' > > + dstportstart='0x100' dstportend='0x1111' > > + comment='`ls`;${COLUMNS};$(ls);"test";&'3 > spaces''/> > > Should we also be testing \, <, or *? Also, your tests for " and ' are > balanced; do unbalanced " or ' expose any problems? None of them show any problems at the moment but in case the implementation ever got changed I guess it's better to have more automated tests (TCK). I'll add some more test cases. > > But this is indeed a useful patch, given the churn I'm putting you > through on the rest of the series :) I hope so :-) Stefan > > -- > Eric Blake ebl...@redhat.com +1-801-349-2682 > Libvirt virtualization library http://libvirt.org
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list