On 11/12/2010 01:59 PM, Eric Blake wrote: > On 11/12/2010 01:50 PM, Matthias Bolte wrote: >> This also fixes configure problems on FreeBSD, as test doesn't >> understand '==' there. >> --- >> configure.ac | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) > > I'm surprised 'make syntax-check' isn't catching these. Maybe I can > whip that one into shape quickly... > >> >> diff --git a/configure.ac b/configure.ac >> index f691c27..66237e1 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -269,9 +269,9 @@ fi >> >> AC_MSG_CHECKING([where to write libvirtd PID file]) >> AC_ARG_WITH([remote-pid-file], >> [AC_HELP_STRING([--with-remote-pid-file=@<:@pidfile|none@:>@], [PID file for >> libvirtd])]) >> -if test "x$with_remote_pid_file" == "x" ; then >> +if test "x$with_remote_pid_file" = "x" ; then > > Meanwhile, ACK.
I just added a gnulib 'make syntax-check' rule, which caught one additional instance: nwfilter_ebiptables_driver.c:653 -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
