On Tue, May 24, 2011 at 04:34:47PM +0100, Stefan Hajnoczi wrote: > On Tue, May 24, 2011 at 3:13 PM, Adam Litke <a...@us.ibm.com> wrote: > Looks like we're close to converging here. I am going to update the > QEMU-side patches to this new API. > > > /** > > * virDomainBlockPull: > > * @dom: pointer to domain object > > * @path: Fully-qualified filename of disk > > * @pos: A pointer to a virDomainBlockPullInfo structure, or NULL > > * @flags: currently unused, for future extension > > * > > * Populate a disk image with data from its backing image. Once all data > > from > > * its backing image has been pulled, the disk no longer depends on a > > backing > > * image. This function works incrementally, performing a small amount of > > work > > * each time it is called. When successful, @pos is updated with the > > current > > * progress. > > * > > * Returns -1 in case of failure, 0 when successful. > > */ > > int virDomainBlockPull(virDomainPtr dom, > > const char *path, > > virDomainBlockPullInfoPtr *pos, > > I think you mean: > virDomainBlockPullInfoPtr info,
This proposal looks fine with that obvious typo fix. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
