2011/6/14 Daniel P. Berrange <berra...@redhat.com>: > On Tue, Jun 07, 2011 at 05:11:15PM +0800, Lai Jiangshan wrote: >> Signed-off-by: Lai Jiangshan <la...@cn.fujitsu.com> >> --- >> src/remote/remote_driver.c | 1 + >> src/remote/remote_protocol.x | 16 +++++++++++++++- >> src/remote_protocol-structs | 11 +++++++++++ >> 3 files changed, 27 insertions(+), 1 deletions(-) >> >> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c >> index 8335a1a..f08a609 100644 >> --- a/src/remote/remote_driver.c >> +++ b/src/remote/remote_driver.c >> @@ -6337,6 +6337,7 @@ static virDriver remote_driver = { >> .domainMigratePerform3 = remoteDomainMigratePerform3, /* 0.9.2 */ >> .domainMigrateFinish3 = remoteDomainMigrateFinish3, /* 0.9.2 */ >> .domainMigrateConfirm3 = remoteDomainMigrateConfirm3, /* 0.9.2 */ >> + .domainSendKey = remoteDomainSendKey, /* 0.9.3 */ >> }; >> >> static virNetworkDriver network_driver = { >> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x >> index c9b8cff..2126325 100644 >> --- a/src/remote/remote_protocol.x >> +++ b/src/remote/remote_protocol.x >> @@ -191,6 +191,11 @@ const REMOTE_SECRET_UUID_LIST_MAX = 16384; >> */ >> const REMOTE_CPU_BASELINE_MAX = 256; >> >> +/* >> + * Max number of sending keycodes. >> + */ >> +const REMOTE_SEND_KEY_MAX = 16; > > Should call this REMOTE_DOMAIN_SEND_KEY_MAX really >
And I still wonder why we go with such a low limit here that is not documented anywhere. If an applications tries to send 17 key strokes in one call it'll just fail with an RPC error. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list