On 09/19/2011 12:47 AM, Matthias Bolte wrote:
2011/9/18<a...@redhat.com>:
* src/vmx/vmx.c: fix memory leak.
Signed-off-by: Alex Jia<a...@redhat.com>
---
src/vmx/vmx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index dff3599..1ab15b7 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
@@ -1253,6 +1253,7 @@ virVMXParseConfig(virVMXContext *ctx, virCapsPtr caps,
const char *vmx)
/* Allocate domain def */
if (VIR_ALLOC(def)< 0) {
virReportOOMError();
+ virConfFree(conf);
return NULL;
}
Your patch is correct.
But I'd suggest to replace the 'return NULL' with a 'goto cleanup'
here instead of adding a virConfFree, as this is more in line with the
surrounding code.
Either way ACK.
Yeah, 'def' has a initial value 'NULL', so 'goto cleanup' is perfected
instead of adding a virConfFree.
Matthias, thanks for your good suggestion, I will commit v2 patch for this.
Regards,
Alex
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
