Same comment as for "interface", do we want to have specialized classes for various type.
In this case, you should also add a base Graphics class. > +GVirConfigGraphicsSpice *gvir_config_graphics_spice_new_from_xml(const gchar > *xml, > + GError > **error) > +{ > + GVirConfigObject *object; > + > + object = gvir_config_object_new_from_xml(GVIR_TYPE_CONFIG_GRAPHICS_SPICE, > + "graphics", NULL, xml, error); > +// xmlNewProp(doc->children, (xmlChar*)"type", (xmlChar*)"spice"); > + return GVIR_CONFIG_GRAPHICS_SPICE(object); > +} This surely shouldn't be commented out. Perhaps it should be done in _init(). -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list