On Thu, Feb 09, 2012 at 04:32:46PM -0700, Eric Blake wrote: > On 02/06/2012 12:21 AM, Daniel Veillard wrote: > > We are now entering the freeze for libvirt-0.9.10 > > Hopefully all the API changes needed for that version are > > already commited to git head. > > > > I have made a release candidate 1 tarball (and associated rpms) at > > ftp://libvirt.org/libvirt/libvirt-0.9.10-rc1.tar.gz > > and the git tree is tagged. > > > > I think I will make an release candidate 2 tarball on Wednesday, and > > I'm hoping for a final release next Monday the 13th. > > > > Please give it a try ! > > I'm wondering if we're too late for one more API to round out the API we > added in this release. Qemu is proposing a new monitor command > system_wakeup which lets the host inject a power-button wakeup to a > guest that has gone into S3 sleep. Since we added the > virDomainPMSuspendForDuration command to put the guest into S3 from the > host, I think we need a counterpart API that wakes the guest back up, > rather than relying on mouse clicks, serial input, or timeouts doing the > job for us. It's a shame that virDomainResume() has no flags argument, > and that it is already tied to virDomainSuspend() (aka guest pause), so > I'm thinking something like: > > /* Inject a wakeup into the guest that previously used > * virDomainPMSuspendForDuration, rather than waiting for the > * previously requested duration (if any) to elapse. */ > int virDomainPMWakeup(virDomainPtr dom, unsigned int flags);
Just to throw this out there, could we not simply implement the rest of the power states in this API? Kind of late to be asking this question, I suppose, but we haven't released this API yet, could we change its name to virDomainPMSetPowerStateForDuration? Dave > -- > Eric Blake ebl...@redhat.com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
