On 04/13/2012 03:55 AM, Jiri Denemark wrote: > On Mon, Apr 09, 2012 at 21:52:15 -0600, Eric Blake wrote: >> Rather than further overloading 'blockpull', I decided to create a >> new virsh command to expose the new flags of virDomainBlockRebase. >> >> Someday, I'd also like to make blockpull and blockcopy have a >> synchronous mode, which blocks until the event happens or Ctrl-C >> is pressed, as well as a --verbose flag to print status updates >> before the job finishes - but not today.
Actually, I ended up doing this for v5 :)
>> +
>> +static const vshCmdOptDef opts_block_copy[] = {
>> + {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")},
>> + {"path", VSH_OT_DATA, VSH_OFLAG_REQ, N_("Fully-qualified path of
>> disk")},
>> + {"dest", VSH_OT_DATA, VSH_OFLAG_REQ, N_("path of the copy to create")},
>> + {"bandwidth", VSH_OT_DATA, VSH_OFLAG_NONE, N_("Bandwidth limit in
>> MB/s")},
>> + {"shallow", VSH_OT_BOOL, 0, N_("make the copy share a backing chain")},
>> + {"reuse-external", VSH_OT_BOOL, 0, N_("reuse existing destination")},
>> + {"raw", VSH_OT_BOOL, 0, N_("use raw destination file")},
>> + {NULL, 0, 0, NULL}
>> +};
>
> You are pretty inconsistent in upper/lower-case letter at the beginning of
> each description string.
Copy-and-paste strikes again. I think we've been favoring lower-case
elsewhere, so I'll make it consistent on the respin.
--
Eric Blake ebl...@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
