On 07/20/2012 08:18 AM, Daniel P. Berrange wrote: >>> @@ -463,6 +480,9 @@ void virNetClientFree(virNetClientPtr client) >>> return; >>> } >>> >>> + if (client->closeFf && client->closeOpaque) >>> + client->closeFf(client->closeOpaque); >> >> Again, you should not be forcing closeOpaque to be non-NULL. It's >> opaque, after all. > > If opaque is NULL, then there's nothing that needs free'ing.
Maybe nothing to free, but there may still be side effects (such as logging) in the closeFf that the caller still wants to have happen. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
