make rpm was failing with the following error:

Entering directory `/home/laine/devel/libvirt/tests'
make[2]: *** No rule to make target `viratomicdata.h',
             needed by `distdir'.  Stop.

viratomicdata.h is listed in tests/Makefile.am as a dependency of
viratomictest, but doesn't exist, is never referenced, and removing
that dependency permits make rpm to complete successfully.

I'm assuming this was a cut-paste error, or a half-finished idea, but
since I didn't know for sure, I didn't push this patch, even though it
fixes a broken build.
---
 tests/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index ac26bc5..2fdaace 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -531,7 +531,7 @@ virhashtest_SOURCES = \
 virhashtest_LDADD = $(LDADDS)
 
 viratomictest_SOURCES = \
-       viratomictest.c viratomicdata.h testutils.h testutils.c
+       viratomictest.c testutils.h testutils.c
 viratomictest_LDADD = $(LDADDS)
 
 jsontest_SOURCES = \
-- 
1.7.11.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to