On 11/13/2012 05:54 AM, Viktor Mihajlovski wrote: > Modified the places where virNodeGetInfo was used for the purpose > of obtaining the maximum node CPU number. Transparently falling > back to virNodeGetInfo in case of failure. > Wrote a utility function getPyNodeCPUCount for that purpose. > > Signed-off-by: Viktor Mihajlovski <mihaj...@linux.vnet.ibm.com> > --- > V2 Changes: > Implemented Eric Blake's suggestion to remove code bloat > introduced by first patch version. > New helper function getPyNodeCPUCount is now used to calculate > the number of node CPUs. > > python/libvirt-override.c | 87 > ++++++++++++++++++++++++++++------------------- > 1 file changed, 52 insertions(+), 35 deletions(-) >
> @@ -1599,23 +1620,19 @@ libvirt_virDomainGetVcpuPinInfo(PyObject *self
> ATTRIBUTE_UNUSED,
> PyObject *args) {
>
> - LIBVIRT_BEGIN_ALLOW_THREADS;
> - i_retval = virNodeGetInfo(virDomainGetConnect(domain), &nodeinfo);
> - LIBVIRT_END_ALLOW_THREADS;
> - if (i_retval < 0)
> - return VIR_PY_NONE;
> + if ((cpunum = getPyNodeCPUCount(virDomainGetConnect(domain))) < 0)
> + return VIR_PY_INT_FAIL;
Oops - unintentional type change, due to too much copy-n-paste.
ACK with that fixed, and pushed.
--
Eric Blake ebl...@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
