On Fri, Dec 14, 2012 at 04:08:24PM +0100, Viktor Mihajlovski wrote: > There was a double free issue caused by virSysinfoRead on s390, > as the same manufacturer string instance was assigned to more > than one processor record. > Cleaned up other potential memory issues and restructured the sysinfo > parsing code by moving repeating patterns into a helper function. > > The restructuring made it necessary to conditionally disable > -Wlogical-op for some older GCC versions, using pragma GCC diagnostic. > This is a GCC specific pragma, which is acceptable, since we're > using it to work around a GCC specific bug. > > Finally, added a function virSysinfoSetup to configure the sysinfo > data source files/script during run time, to facilitate writing test > programs. This function is not published in sysinfo.h and only > there for testing. > > Signed-off-by: Viktor Mihajlovski <mihaj...@linux.vnet.ibm.com> > --- > V3: > added missing prototype for virSysinfoSetup > > src/libvirt_private.syms | 1 + > src/util/sysinfo.c | 195 > ++++++++++++++++++++++++---------------------- > 2 files changed, 102 insertions(+), 94 deletions(-)
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
