On Mon, Feb 25, 2013 at 10:04:07PM +0100, Andreas Färber wrote: > Am 21.02.2013 21:57, schrieb Eduardo Habkost: > > On Thu, Feb 21, 2013 at 09:23:22PM +0100, Markus Armbruster wrote: > >> Eduardo Habkost <ehabk...@redhat.com> writes: > >> > >>> This allows "," to be used a separator between each CPU range. Note > >>> that commas inside key=value command-line options have to be escaped > >>> using ",,", so the command-line will look like: > >>> > >>> -numa node,cpus=A,,B,,C,,D > >> > >> This is really, really ugly, and an embarrassment to document. Which > >> you didn't ;) > > > > I was trying to have an intermediate solution using the current -numa > > parser. I have patches in my queue that will change the code to properly > > use QemuOpts later. > > Speaking of which, have you considered using QemuOpts for -cpu? Its > custom parsing code will probably not handle , escaping at all. ;)
It may be possible, but I'm not sure QemuOpts can handle the "+foo,-foo" options (and I am sure we don't want to extend QemuOpts to support them). In either case, it's better to do that after we simplify x86_cpu_parse_featurestr() (with the current patches from Igor), to make the conversion easier to review later. -- Eduardo -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list