On Tue, Mar 19, 2013 at 12:21:31PM +0100, Jiri Denemark wrote: > On Wed, Mar 13, 2013 at 15:24:03 +0000, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" <berra...@redhat.com> > > > > If no user identity is available, some operations may wish to > > use the system identity. ie the identity of the current process > > itself. Add an API to get such an identity. > > > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > src/util/viridentity.c | 71 > > ++++++++++++++++++++++++++++++++++++++++++++++++++ > > src/util/viridentity.h | 2 ++ > > 2 files changed, 73 insertions(+) > > > > diff --git a/src/util/viridentity.c b/src/util/viridentity.c > > index acb0cb9..1c43081 100644 > > --- a/src/util/viridentity.c > > +++ b/src/util/viridentity.c > ... > > @@ -116,6 +122,71 @@ int virIdentitySetCurrent(virIdentityPtr ident) > > > > > > /** > > + * virIdentityGetSystem: > > + * > > + * Returns an identity that represents the system itself. > > + * This is the identity that the process is running as > > + * > > + * Returns a reference to the system identity, or NULL > > + */ > > +virIdentityPtr virIdentityGetSystem(void) > > +{ > > + char *username = NULL; > > + char *groupname = NULL; > > + char *seccontext = NULL; > > + virIdentityPtr ret = NULL; > > + gid_t gid = getgid(); > > + uid_t uid = getuid(); > > +#if HAVE_SELINUX > > + security_context_t con; > > +#endif > > + > > + if (!(username = virGetUserName(uid))) > > + goto cleanup; > > + if (!(groupname = virGetGroupName(gid))) > > + goto cleanup; > > Quite cosmetic, but is there any reason why we use uid/gid variables > rather than calling getuid/getgid directly here?
No particular reason, I'll change that. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list