On Tue, Apr 02, 2013 at 02:19:35PM -0600, Eric Blake wrote: > On 04/02/2013 08:22 AM, Michal Privoznik wrote: > > --- > > src/libvirt_private.syms | 1 + > > src/qemu/qemu_domain.c | 4 +--- > > src/util/viraudit.c | 2 +- > > src/util/vircommand.c | 4 ++-- > > src/util/virerror.c | 2 +- > > src/util/virlog.c | 2 +- > > src/util/virstring.c | 22 ++++++++++++++++++++-- > > src/util/virstring.h | 3 +++ > > 8 files changed, 30 insertions(+), 10 deletions(-) > > > > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms > > index 5060b87..8d1abe7 100644 > > --- a/src/libvirt_private.syms > > +++ b/src/libvirt_private.syms > > @@ -1742,6 +1742,7 @@ virStrToLong_ul; > > virStrToLong_ull; > > virTrimSpaces; > > virVasprintf; > > +virVasprintfNOOM; > > Bike-shedding: Maybe virVasprintfQuiet works better? I'm a bit worried > that the NOOM suffix will cause more questions than it resolves about > what it is really doing, which is being silent on OOM conditions.
I agree, the name suggests that it isn't doing any error checking at all, which is obviously not the case. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
