Hi Osier, On Thu, May 16, 2013 at 12:37:23AM +0800, Osier Yang wrote: [..snip..] > >Not sure I really agree with this change. The 'fchostdata' files are > >used by the 'fchosttest.c' test program. So that existing naming is > >following our conventions of naming the data dir to match the test > >program. > > > My intention was to put all the sysfs test input files together in a > directory, and keep the tree similar with real "sysfs". IMHO it's > better than having different sysfs test input files here and there, > and orgnize the tree of each of them in different manner?
I think there's pros and cons for both. With different minimal sysfs trees we'd have a minimal test fixture so we can be sure other test data doesn't influence the outcome. So I kind of agree with Daniel's PoV here. -- Guido -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
