During a recent discussion about calling regfree() when regcomp() fails, we decided it was best to not call regfree() when compilation fails.
https://www.redhat.com/archives/libvir-list/2013-September/msg00262.html The first patch fixes existing infractions throughout the code. I split the second patch out since there were other issues beyond simply removing a call to regfree(). Jim Fehlig (2): Don't call regfree() if regcomp() fails libxl: Compile regular expression where it is used src/libxl/libxl_conf.c | 29 +++++++++++++++-------------- src/storage/storage_backend.c | 2 +- src/storage/storage_backend_logical.c | 1 - src/xen/xen_hypervisor.c | 3 --- 4 files changed, 16 insertions(+), 19 deletions(-) -- 1.8.1.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
