On 09/23/13 15:23, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berra...@redhat.com> > > If OOM occurs in qemuDomainCCWAddressSetCreate, it jumps to > a cleanup block and frees the partially initialized object. > It then mistakenly returns the address of the just free'd > pointer instead of NULL. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > src/qemu/qemu_command.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c > index e6239c9..b20149b 100644 > --- a/src/qemu/qemu_command.c > +++ b/src/qemu/qemu_command.c > @@ -1275,7 +1275,7 @@ qemuDomainCCWAddressSetCreate(void) > > cleanup:
The label should be then called "error" > qemuDomainCCWAddressSetFree(addrs); > - return addrs; > + return NULL; > } > > /* > ACK nevertheless.
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
