From: "Daniel P. Berrange" <berra...@redhat.com>
If xenParseSxprPCI failed to expand the def->hostdevs array
due to OOM, it would free the hostdev instance twice.
Signed-off-by: Daniel P. Berrange <berra...@redhat.com>
---
src/xenxs/xen_sxpr.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c
index bb8a335..3cbe958 100644
--- a/src/xenxs/xen_sxpr.c
+++ b/src/xenxs/xen_sxpr.c
@@ -1055,10 +1055,8 @@ xenParseSxprPCI(virDomainDefPtr def,
dev->source.subsys.u.pci.addr.slot = slotID;
dev->source.subsys.u.pci.addr.function = funcID;
- if (VIR_REALLOC_N(def->hostdevs, def->nhostdevs+1) < 0) {
- virDomainHostdevDefFree(dev);
+ if (VIR_REALLOC_N(def->hostdevs, def->nhostdevs+1) < 0)
goto error;
- }
def->hostdevs[def->nhostdevs++] = dev;
}
--
1.8.3.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
