On Mon, Nov 25, 2013 at 8:26 PM, Laine Stump <la...@laine.org> wrote: > On 11/21/2013 04:41 PM, Ryota Ozaki wrote: >> vbox_CAPI_v4_3.h is almost same as sdk/bindings/xpcom/include/VBoxCAPI_v4_3.h >> of >> http://download.virtualbox.org/virtualbox/4.3.2/VirtualBoxSDK-4.3.2-90405.zip, >> but modified to fix preprocessor indentations by using cppi. >> >> Signed-off-by: Ryota Ozaki <ozaki.ry...@gmail.com> >> --- >> src/vbox/vbox_CAPI_v4_3.h | 10210 >> ++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 10210 insertions(+) >> create mode 100644 src/vbox/vbox_CAPI_v4_3.h > > Sigh. I see from the existing code in the vbox directory that importing > the entire (very long)( header file (with small tweaks such as proper > indentation for cppi) is standard practice, so ACK to this. But I can't > let it go by without asking - is there really no standard set of header > files for vbox development that can/should be distributed separately?
Yes, unfortunately :-/ > > Note the one correction below, though. > >> >> diff --git a/src/vbox/vbox_CAPI_v4_3.h b/src/vbox/vbox_CAPI_v4_3.h >> new file mode 100644 >> index 0000000..92d810b >> --- /dev/null >> +++ b/src/vbox/vbox_CAPI_v4_3.h >> @@ -0,0 +1,10210 @@ >> +/* >> + * Libvirt notice: this file is derived from the VirtualBox SDK, with >> + * libvirt edits (fixing preprocessor indentation by cppi); do not >> + * regenerate in the context of libvirt. >> + */ >> +/* >> + * DO NOT EDIT! This is a generated file. >> + * >> + * XPCOM IDL (XPIDL) definition for VirtualBox Main API (COM interfaces) >> + * generated from XIDL (XML interface definition). >> + * >> + * Source : src/VBox/Main/idl/VirtualBox.xidl >> + * Generator : src/VBox/Main/idl/xpcidl.xsl >> + * >> + * This file contains portions from the following Mozilla XPCOM files: >> + * xpcom/include/xpcom/nsID.h >> + * xpcom/include/nsIException.h >> + * xpcom/include/nsprpub/prtypes.h >> + * xpcom/include/xpcom/nsISupportsBase.h >> + * >> + * These files were originally triple-licensed (MPL/GPL2/LGPL2.1). Oracle >> + * elects to distribute this derived work under the LGPL2.1 only. >> + */ >> + >> +/* >> + * Copyright (C) 2008-2012 Oracle Corporation >> + * >> + * This file is part of a free software library; you can redistribute >> + * it and/or modify it under the terms of the GNU Lesser General >> + * Public License version 2.1 as published by the Free Software >> + * Foundation and shipped in the "COPYING" file with this library. > > Since the file is released under LGPL, it should refer to the file > "COPYING.LESSER" instead. I've made that change and pushed it. Thanks for the tweak! (hmm, their SDK doesn't include even COPYING file...) ozaki-r > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
